[DRIVERS-2501] Break NoWritesPerformed-Only Error Sequence Created: 09/Nov/22 Updated: 05/Dec/22 |
|
| Status: | Implementing |
| Project: | Drivers |
| Component/s: | Retryability |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Unknown |
| Reporter: | Preston Vasquez | Assignee: | Preston Vasquez |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | retryable-writes | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Driver Changes: | Needed | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Downstream Changes Summary: | Drivers should sync unified retryable-writes spec tests to mongodb/specifications@2051f35. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Driver Compliance: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
|
In the previous specification for executing retryable writes, there is an edge case where the server only returns errors with the "NoWritesPerformed" error label. If this happens, the following block is unreachable:
In this case, the previousError that will be propagated to the user will be "null". In reality, this routine should propagate the first NoWritesPerformed-labeled error. |
| Comments |
| Comment by Jeffrey Yemin [ 05/Dec/22 ] |
|
preston.vasquez@mongodb.com julius.park@mongodb.com is it the case that a driver could pass the new test but still have the bug described by this issue, at least until DRIVERS-2504 is addressed? |
| Comment by Githook User [ 02/Dec/22 ] |
|
Author: {'name': 'Preston Vasquez', 'email': '24281431+prestonvasquez@users.noreply.github.com', 'username': 'prestonvasquez'}Message: DRIVERS-2501 Break NoWritesPerformed-Only Error Sequence (#1349) |
| Comment by Julius Park (Inactive) [ 17/Nov/22 ] |
|
I believe we also need to add cases for some of the following cases:
4 and 2 are implemented by the previous PR and this one, respectively. |
| Comment by Jeremy Mikola [ 16/Nov/22 ] |
|
Cross-referencing with:
preston.vasquez@mongodb.com: Is this likely something that was missed during review in mongodb/specifications#1317? /cc shane.harvey@mongodb.com |