[DRIVERS-2577] Add runCommand specification and remove readConcern and writeConcern options from unified test runCommand operation Created: 22/Mar/23 Updated: 21/Aug/23 |
|
| Status: | Implementing |
| Project: | Drivers |
| Component/s: | Unified Test Runner |
| Fix Version/s: | None |
| Type: | Spec Change | Priority: | Unknown |
| Reporter: | Neal Beeken | Assignee: | Neal Beeken |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Driver Changes: | Needed | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Downstream Changes Summary: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Engineering Lead: | |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Start date: | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Driver Compliance: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
SummaryAdd a runCommand specification based on the runCommand requirements called out by other specs. Additionally, The unified test format runCommand operation states that readConcern and writeConcern are supported options. However, runCommand implementations are not supposed to apply readConcern nor writeConcern options and users are instead expected to define those settings on the command document themselves. We currently do not have unified tests that use these options. Any driver that implemented support for them in their unified runner can remove the logic in favor of potential future tests that put these settings in the command documents themselves. MotivationWho is the affected end user?Driver engineers with a unified test runner. How does this affect the end user?N/A How likely is it that this problem or use case will occur?Removing the options now can prevent any tests from utilizing them as we add more unified tests to our specifications. If the problem does occur, what are the consequences and how severe are they?N/A Is this issue urgent?Not urgent. We need to take care about not adding tests that rely on these options as currently the docs will not inform a spec writer they are intended to be removed and are not supported in most drivers. Is this ticket required by a downstream team?No. Is this ticket only for tests?Yes Acceptance Criteria
|
| Comments |
| Comment by Githook User [ 09/May/23 ] |
|
Author: {'name': 'Jeremy Mikola', 'email': 'jmikola@gmail.com', 'username': 'jmikola'}Message: DRIVERS-2577: $readPreference is not sent to standalone server (#1416) Also test that primary $readPreference is never set |
| Comment by Jeremy Mikola [ 08/May/23 ] |
|
PR to fix test failures on standalones: https://github.com/mongodb/specifications/pull/1416 |
| Comment by Githook User [ 25/Apr/23 ] |
|
Author: {'name': 'Neal Beeken', 'email': 'neal.beeken@mongodb.com', 'username': 'nbbeeken'}Message: DRIVERS-2577: runCommand set min server version correctly (#1410) |
| Comment by Githook User [ 21/Apr/23 ] |
|
Author: {'name': 'Neal Beeken', 'email': 'neal.beeken@mongodb.com', 'username': 'nbbeeken'}Message: DRIVERS-2577: add a runCommand specification (#1389) Co-authored-by: Jeremy Mikola <jmikola@gmail.com> |