[DRIVERS-2612] Bump minServerVersion for CSFLE deterministic encryption spec test for explain command Created: 21/Apr/23 Updated: 21/Aug/23 |
|
| Status: | Implementing |
| Project: | Drivers |
| Component/s: | Client Side Encryption |
| Fix Version/s: | None |
| Type: | Task | Priority: | Minor - P4 |
| Reporter: | Jeremy Mikola | Assignee: | Jeremy Mikola |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Driver Changes: | Needed | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Server Compat: | 7.0, 7.1 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Downstream Changes Summary: | Sync legacy CSFLE spec tests to mongodb/specifications@08c206e. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Engineering Lead: | |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Start date: | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Driver Compliance: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
SummaryThe "Explain a find with deterministic encryption" test in explain.yml has historically failed when Testing with required API version due to a bug in crypt_shared (
If drivers previously had no record of this test failure, it's likely they were never running CSFLE spec tests (specifically with crypt_shared) while requiring an API version. That'd be worth looking into as part of this issue (and should be communicated in downstream changes). MotivationWho is the affected end user?Driver test suites. How does this affect the end user?A CSFLE spec test has historically failed when run with a required API version. How likely is it that this problem or use case will occur?All drivers should have experienced a test failure. If they did not, it's likely they were not running CSFLE tests with a required API version, which would violate the Stable API test guidelines. Is this issue urgent?No. Is this ticket required by a downstream team?No. Is this ticket only for tests?Yes. |
| Comments |
| Comment by Githook User [ 23/Jun/23 ] |
|
Author: {'name': 'Jeremy Mikola', 'email': 'jmikola@gmail.com', 'username': 'jmikola'}Message: DRIVERS-2612: Require 7.0+ for explain apiVersion bug fix (#1435) In previous server versions, apiVersion is not properly appended to the root of an explain command document. When testing with requireApiVersion=1, that can cause test failures if the driver does not have additional logic to always append the field to a crypt_shared/mongocryptd response. |
| Comment by Jeremy Mikola [ 16/Jun/23 ] |
| Comment by Kevin Albertson [ 11/May/23 ] |
|
Here is a patch build of the PHP driver with the test unskipped: The error does not reproduce in the Go driver using server 6.0.4 and crypt_shared 6.0.4. The Go driver appends apiVersion after encrypting the command. The command sent from the Go driver includes the apiVersion at the root of the document. Filed |