[DRIVERS-2675] Remove use of "sharded-replicaset" in runCommand spec tests Created: 17/Jul/23  Updated: 28/Oct/23  Resolved: 19/Jul/23

Status: Closed
Project: Drivers
Component/s: Unified Test Runner
Fix Version/s: None

Type: Task Priority: Minor - P4
Reporter: Jeremy Mikola Assignee: Jeremy Mikola
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by DRIVERS-2663 Remove sharded-replicaset topology ty... Closed
Issue split
split to PHPLIB-1205 Sync runCommand spec tests for remova... Closed
Related
is related to DRIVERS-2609 Deprecate sharded-replicaset topology... Implementing
is related to DRIVERS-2577 Add runCommand specification and remo... Implementing
Driver Changes: Not Needed
Driver Compliance:
Key Status/Resolution FixVersion
PHPLIB-1205 Fixed 1.17.0

 Description   

Summary

I came across two instances of "sharded-replicaset" in source/run-command/tests/unified/runCommand.yml. These were introduced in d697477 and ab66eaf for DRIVERS-2577. That work was merged around the same time as DRIVERS-2609, which deprecated use of "sharded-replicaset".

We can safely remove these two occurrences of "sharded-replicaset" and there is no need to require driver changes since it's not a sensitive change.

Motivation

Is this issue urgent?

No.

Is this ticket required by a downstream team?

No.

Is this ticket only for tests?

Yes.



 Comments   
Comment by Jeremy Mikola [ 19/Jul/23 ]

PR: https://github.com/mongodb/specifications/pull/1443

Note: I skipped "Driver Changes: Needed" to avoid spawning tickets. This change should have no impact on whether tests fail/pass in drivers, so it can be pulled in with future updates to the test files that do require a test sync.

Comment by Githook User [ 19/Jul/23 ]

Author:

{'name': 'Jeremy Mikola', 'email': 'jmikola@gmail.com', 'username': 'jmikola'}

Message: DRIVERS-2675: Remove use of "sharded-replicaset" (#1443)

Although one test does not specify a minServerVersion, "sharded-replicaset" is still redundant since $readPreference is always sent to mongos.
Branch: master
https://github.com/mongodb/specifications/commit/9d7ceed8c37bafb5769787c26c8f8c79670f94f8

Generated at Thu Feb 08 08:26:09 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.