[DRIVERS-2675] Remove use of "sharded-replicaset" in runCommand spec tests Created: 17/Jul/23 Updated: 28/Oct/23 Resolved: 19/Jul/23 |
|
| Status: | Closed |
| Project: | Drivers |
| Component/s: | Unified Test Runner |
| Fix Version/s: | None |
| Type: | Task | Priority: | Minor - P4 |
| Reporter: | Jeremy Mikola | Assignee: | Jeremy Mikola |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Driver Changes: | Not Needed | ||||||||||||||||||||||||||||
| Driver Compliance: |
|
||||||||||||||||||||||||||||
| Description |
SummaryI came across two instances of "sharded-replicaset" in source/run-command/tests/unified/runCommand.yml. These were introduced in d697477 and ab66eaf for DRIVERS-2577. That work was merged around the same time as DRIVERS-2609, which deprecated use of "sharded-replicaset". We can safely remove these two occurrences of "sharded-replicaset" and there is no need to require driver changes since it's not a sensitive change. MotivationIs this issue urgent?No. Is this ticket required by a downstream team?No. Is this ticket only for tests?Yes. |
| Comments |
| Comment by Jeremy Mikola [ 19/Jul/23 ] |
|
PR: https://github.com/mongodb/specifications/pull/1443 Note: I skipped "Driver Changes: Needed" to avoid spawning tickets. This change should have no impact on whether tests fail/pass in drivers, so it can be pulled in with future updates to the test files that do require a test sync. |
| Comment by Githook User [ 19/Jul/23 ] |
|
Author: {'name': 'Jeremy Mikola', 'email': 'jmikola@gmail.com', 'username': 'jmikola'}Message: Although one test does not specify a minServerVersion, "sharded-replicaset" is still redundant since $readPreference is always sent to mongos. |