[DRIVERS-2799] Test-level runOnRequirements in retryable writes tests should not be more permissive than top-level runOnRequirements Created: 19/Dec/23 Updated: 20/Dec/23 |
|
| Status: | Implementing |
| Project: | Drivers |
| Component/s: | Retryability |
| Fix Version/s: | None |
| Type: | Task | Priority: | Minor - P4 |
| Reporter: | Jeremy Mikola | Assignee: | Jeremy Mikola |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Driver Changes: | Needed | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Downstream Changes Summary: | Summary of necessary driver changes
Commits for syncing spec/prose tests
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Engineering Lead: | |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Start date: | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Driver Compliance: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
SummaryThe unified spec tests introduced in ab48c57 for DRIVERS-1385 incorrectly specify top-level runOnRequirements that are more restrictive than the test-level runOnRequirements. Those tests may have been copied from the original poc-retryable-writes.yml tests introduced in e4808b8 for DRIVERS-709, which have the same issue. This is contrary to the advice in the Unified Test Format spec:
As currently written, the spec tests will never run on sharded clusters and load balancers because the top-level runOnRequirements require a replica set. MotivationIs this issue urgent?No. Is this ticket required by a downstream team?No. Is this ticket only for tests?Yes. |
| Comments |
| Comment by Githook User [ 20/Dec/23 ] |
|
Author: {'name': 'Jeremy Mikola', 'email': 'jmikola@gmail.com', 'username': 'jmikola'}Message: DRIVERS-2799: Use more permissive top-level runOnRequirements (#1484)
This avoids unintentionally skipping tests. Previously, some tests were never run on sharded clusters.
This ensures the unified test is consistent with the legacy test from which it was derived. Additionally, it makes the test resilient to possible changes in DRIVERS-1641. This inconsistency dates back to e4808b84f804f8b08293dcd51ce107e10a40589f. |
| Comment by Jeremy Mikola [ 19/Dec/23 ] |
| Comment by Jeremy Mikola [ 19/Dec/23 ] |
|
Encountered this while working on DRIVERS-1641. |