[DRIVERS-2802] Require 4.3.1+ server version when using failCommand errorLabels option Created: 02/Jan/24 Updated: 12/Jan/24 |
|
| Status: | Implementing |
| Project: | Drivers |
| Component/s: | Unified Test Runner |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Unknown |
| Reporter: | Jeremy Mikola | Assignee: | Jeremy Mikola |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Driver Changes: | Needed | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Downstream Changes Summary: | Sync the following spec tests with mongodb/specifications@8de8180:
Update retryable writes prose test #3 to account for moving errorLabels to the top-level of the fail point configuration. Additionally, confirm that server version requirements for all modified prose tests are accurate. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Engineering Lead: | |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Start date: | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Driver Compliance: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
SummaryVarious spec tests (both legacy and unified) utilize the errorLabels option for the failCommand fail point without requiring server version 4.3.1+, which is when the option was first implemented ( I came across this issue while implementing DRIVERS-1641, which changes drivers to no longer inspect writeConcernError.code on pre-4.4 mongos responses and instead rely entirely on the server-populated error labels. On versions of mongos prior to 4.3.1, those error labels may not be populated due to failCommand ignoring the errorLabels option used in the test. We should also note this requirement in the Unified Test Format spec, which documents the failCommand fail point. MotivationIs this issue urgent?Requirement for DRIVERS-1641. Is this ticket required by a downstream team?No. Is this ticket only for tests?Yes. |
| Comments |
| Comment by Githook User [ 12/Jan/24 ] |
|
Author: {'name': 'Jeremy Mikola', 'email': 'jmikola@gmail.com', 'username': 'jmikola'}Message: DRIVERS-2802: Fix insertedId expectations in insertOne-errorLabels (#1494) This corrects a mistake introduced in 5fc23f40f79d18f0693e7159eba81f0e7b276715 when these tests were originally moved from insertOne-serverErrors |
| Comment by Jeremy Mikola [ 11/Jan/24 ] |
| Comment by Githook User [ 10/Jan/24 ] |
|
Author: {'name': 'Jeremy Mikola', 'email': 'jmikola@gmail.com', 'username': 'jmikola'}Message: DRIVERS-2802: Require 4.3.1+ when using failCommand errorLabels option (#1489) This also improves version info in the failCommand docs within the Unified Test Format spec. |
| Comment by Jeremy Mikola [ 03/Jan/24 ] |