[DRIVERS-331] BSON Regex flags must be alphabetically ordered Created: 25/Oct/16  Updated: 15/Apr/19  Resolved: 11/Dec/17

Status: Closed
Project: Drivers
Component/s: None
Fix Version/s: None

Type: Improvement Priority: Minor - P4
Reporter: David Golden Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on CXX-1118 BSON Regex flags must be alphabetical... Closed
depends on PHPC-885 Alphabetize Regex flags when instanti... Closed
depends on CXX-1117 BSON Regex flags must be alphabetical... Closed
depends on NODE-848 BSON Regex flags must be alphabetical... Closed
depends on PHPC-829 BSON Regex flags must be alphabetical... Closed
depends on PYTHON-1183 BSON Regex flags must be alphabetical... Closed
depends on RUBY-1170 BSON Regex flags must be alphabetical... Closed
depends on CDRIVER-1883 libbson should ensure regex options a... Closed
depends on CSHARP-2485 Regular expression options must be in... Closed
depends on JAVA-2376 BSON Regex flags must be alphabetical... Closed
Related
related to DRIVERS-82 Don't compile BSON regexes to native ... Closed
related to DOCS-9208 Document requirement that regular exp... Closed
is related to DRIVERS-330 Implement BSON Corpus tests Closed
Driver Compliance:
Key Status/Resolution FixVersion
CDRIVER-1883 Done 1.7.0
SCALA-278 Won't Fix
NODE-848 Done 2.2.12
JAVA-2376 Done 3.4.0
PERL-678 Done
RUBY-1170 Done bson-4.2.0
PYTHON-1183 Done 3.4
CXX-1117 Won't Fix
CXX-1118 Done 3.2.0-rc0
PHPC-829 Done 1.2.0
PHPC-885 Done 1.2.3
CSHARP-2485 Duplicate

 Description   

The BSON Corpus added test cases for regex flags. See this diff for the complete changes.



 Comments   
Comment by Jeremy Mikola [ 13/Jan/17 ]

Validating PHPC due to PHPC-829 and PHPC-885 being resolved. Not relevant for PHPLIB.

derick: I skipped HHVM since you may need to implement an equivalent of PHPC-885.

Comment by Bernie Hackett [ 11/Nov/16 ]

See also SERVER-26992.

Comment by Bernie Hackett [ 11/Nov/16 ]

Oops, ignore my last comment. The sort algorithm is correct.

Comment by Bernie Hackett [ 11/Nov/16 ]

Sadly, the sort algorithm in the server also appears to be incorrect (so this ticket may not matter at all). bjori is going to open another server ticket about that.

Comment by David Golden [ 11/Nov/16 ]

We know sort order matters (now and historically), so let's proceed by getting that right and dropping the invalid checks from the corpus.

Comment by Bernie Hackett [ 11/Nov/16 ]

Let's put this on hold until some decisions are made related to SERVER-26991.

Comment by Jeremy Mikola [ 07/Nov/16 ]

Since the Extended JSON spec is still in progress, would it be worthwhile to add this requirement to its output as well?

Noting the discussion in CDRIVER-1883, this order is primarily for sorting of regular expressions server-side, so there may not be a functional reason to do so for JSON other than consistency when examining different representations of the same driver object.

Generated at Thu Feb 08 08:21:16 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.