|
Hi david.golden, you're correct the Java tests are unit tests that ensure the driver produces the expected read concern document for each value in the json tests. The Java driver also has operation tests that ensure that the command document sent to the server for a given operation is in the expected format. With that combination of tests we can be confident that the readConcern value that is sent to the server is in the correct / expected format.
The Java driver already has tests that ensure arbitrary string values for the readConcern level aren't supported. It looks like read-concern.json just seems to test the happy path - so adding some "valid": false examples would be good.
Adding interaction tests with the server would certainly help ensure there are no accidental regressions / unexpected changes in server behavior in the future. However, that work isn't scheduled at this time.
|