[GODRIVER-1099] Change RetryType to Type Created: 30/May/19  Updated: 28/Oct/23  Resolved: 12/Jul/19

Status: Closed
Project: Go Driver
Component/s: Core API
Affects Version/s: None
Fix Version/s: 1.1.0

Type: Improvement Priority: Major - P3
Reporter: Kristofer Brandow (Inactive) Assignee: Isabella Siu (Inactive)
Resolution: Fixed Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Issue split
split from GODRIVER-1042 Don't add read preference for non-mon... Closed

 Description   

The RetryType is currently used to determine if the driver.Operation needs to do retryable reads or retryable writes. Instead of adding an additional field that would specify if the operation is a read or a write, convert RetryType into Type and convert RetryWrites and RetryReads into Write and Read.

As follow-on work for GODRIVER-1042, also update the createReadPref method to use the Type information to determine if it should return a read preference at all, e.g. the case where we have a direct connection and are not connected to a mongos, wherein we will send a read preference of primary preferred.



 Comments   
Comment by Githook User [ 06/Aug/19 ]

Author:

{'name': 'iwysiu', 'username': 'iwysiu', 'email': 'isabella.siu@10gen.com'}

Message: GODRIVER-1099 Change RetryType to Type

Change-Id: Ib04da47943a4113b20190c021c7cd921b58519be
Branch: fle
https://github.com/mongodb/mongo-go-driver/commit/9ec4480161a76f5267d56fc836b7f6d357fd9209

Comment by Githook User [ 12/Jul/19 ]

Author:

{'name': 'iwysiu', 'email': 'isabella.siu@10gen.com', 'username': 'iwysiu'}

Message: GODRIVER-1099 Change RetryType to Type

Change-Id: Ib04da47943a4113b20190c021c7cd921b58519be
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/9ec4480161a76f5267d56fc836b7f6d357fd9209

Comment by Isabella Siu (Inactive) [ 09/Jul/19 ]

code review url: https://review.gerrithub.io/c/mongodb/mongo-go-driver/+/461062

Generated at Thu Feb 08 08:35:41 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.