[GODRIVER-125] Cursor iteration should complete (abnormally) when another goroutine closes the cursor Created: 10/Nov/17  Updated: 10/Sep/18  Resolved: 10/Sep/18

Status: Closed
Project: Go Driver
Component/s: CRUD
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major - P3
Reporter: Rathi Gnanasekaran Assignee: Unassigned
Resolution: Won't Fix Votes: 0
Labels: Stitch, neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on GODRIVER-490 Cursor.Next should call getMore in a ... Closed
is depended on by DRIVERS-421 Cursor iteration should complete (abn... Closed
Epic Link: Go FY2019Q3 Quick Wins

 Comments   
Comment by Jeffrey Yemin [ 06/Sep/18 ]

CC eric.daniels

Since we can use the Context passed to Cursor.Next for cancellation, we don't need to make Cursor.Close goroutine safe.

kris.brandow if you agree, please close this ticket as Won't Fix.

Comment by Kristofer Brandow (Inactive) [ 20/Aug/18 ]

We need to have a larger discussion around if Cursors should be goroutine safe. If they are not, then this ticket isn't a problem. If they are, then we need to implement this behavior. Either way we also need to add the "spin until we get a document or timeout" behavior.

Comment by Eric Daniels (Inactive) [ 26/Jul/18 ]

SGTM.

Comment by Jeffrey Yemin [ 17/Jul/18 ]

eric.daniels, this is only an issue for drivers that loop calling getMore to wait for the next document from a cursor to show up (or until the server closes the cursor). Currently the Go driver does not have such a loop.

CC kris.brandow

Comment by Roland Fong [ 07/Jun/18 ]

https://review.gerrithub.io/c/mongodb/mongo-go-driver/+/414283

Generated at Thu Feb 08 08:33:35 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.