[GODRIVER-1405] "appname" is not not always sent in isMaster Created: 09/Nov/19 Updated: 28/Oct/23 Resolved: 17/Apr/20 |
|
| Status: | Closed |
| Project: | Go Driver |
| Component/s: | Server Discovery and Monitoring |
| Affects Version/s: | None |
| Fix Version/s: | 1.3.3 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | David Bartley | Assignee: | Divjot Arora (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Description |
|
It appears there's a couple places where isMaster requests are constructed: While both set "appname", the latter uses "s.cfg.appname", but afaict that value is never set (and I've confirmed from logs that client metadata is being received without "application"). This makes sense, since "appname" comes from https://github.com/mongodb/mongo-go-driver/blob/master/x/mongo/driver/topology/server_options.go#L24, but there's no "WithAppName(...) ServerOption" function. |
| Comments |
| Comment by Githook User [ 20/Apr/20 ] |
|
Author: {'name': 'Divjot Arora', 'email': 'divjot.arora@10gen.com', 'username': 'divjotarora'}Message: |
| Comment by Githook User [ 20/Apr/20 ] |
|
Author: {'name': 'Divjot Arora', 'email': 'divjot.arora@10gen.com', 'username': 'divjotarora'}Message: |
| Comment by Githook User [ 20/Apr/20 ] |
|
Author: {'name': 'Divjot Arora', 'email': 'divjot.arora@10gen.com', 'username': 'divjotarora'}Message: |
| Comment by Githook User [ 17/Apr/20 ] |
|
Author: {'name': 'Divjot Arora', 'email': 'divjot.arora@10gen.com', 'username': 'divjotarora'}Message: |
| Comment by Divjot Arora (Inactive) [ 14/Apr/20 ] |
|
Moving back to "Needs Triage". The previous commit fixed the issue when using WithConnString but we need to make this fix in client.go to correctly set the topology/server/connection options and actually propagate the app name. I also didn't realize this when we first did this ticket, but we might be able to add a test using drivertest.ChannelConn or something similar. |
| Comment by Githook User [ 18/Nov/19 ] |
|
Author: {'name': 'iwysiu', 'username': 'iwysiu', 'email': 'isabella.siu@10gen.com'}Message: |