[GODRIVER-1615] SingleConnectionDeployment should not be used for application operations Created: 12/May/20  Updated: 28/Oct/23  Resolved: 03/Jun/20

Status: Closed
Project: Go Driver
Component/s: CRUD
Affects Version/s: None
Fix Version/s: 1.3.4

Type: Bug Priority: Major - P3
Reporter: Divjot Arora (Inactive) Assignee: Divjot Arora (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

The SingleConnectionDeployment has two problems:

  1. It doesn't implement ErrorProcessor, so application errors aren't handled per the SDAM error handling spec. SingleServerDeployment probably has the same issue.
  2. It wraps connections in nopCloserConnection, which prevents any interfaces they implemented like Compressor from being used.

Change streams use these deployment types, so they should be changed.



 Comments   
Comment by Githook User [ 03/Jun/20 ]

Author:

{'name': 'Divjot Arora', 'email': 'divjot.arora@10gen.com', 'username': 'divjotarora'}

Message: GODRIVER-1615 Track wire version on ChangeStream

This was needed to fix test errors. Because the deployment was changed
and the new deployment closes the connection right after the aggregate,
any code that access the wire version after the aggregate finishes would
panic. To fix that, we store the wire version of the last used connection
on ChangeStream.
Branch: release/1.3
https://github.com/mongodb/mongo-go-driver/commit/630989b0608d06a1362d3f6ef0f4811aec55e00e

Comment by Githook User [ 03/Jun/20 ]

Author:

{'name': 'Divjot Arora', 'email': 'divjot.arora@10gen.com', 'username': 'divjotarora'}

Message: GODRIVER-1615 Track wire version on ChangeStream

This was needed to fix test errors. Because the deployment was changed
and the new deployment closes the connection right after the aggregate,
any code that access the wire version after the aggregate finishes would
panic. To fix that, we store the wire version of the last used connection
on ChangeStream.
Branch: release/1.3
https://github.com/mongodb/mongo-go-driver/commit/630989b0608d06a1362d3f6ef0f4811aec55e00e

Comment by Githook User [ 03/Jun/20 ]

Author:

{'name': 'Divjot Arora', 'email': 'divjot.arora@10gen.com', 'username': 'divjotarora'}

Message: GODRIVER-1615 Use custom deployment for change streams (#411)
Branch: release/1.3
https://github.com/mongodb/mongo-go-driver/commit/012750a59251839a3098a9384efb9c252127f660

Comment by Githook User [ 03/Jun/20 ]

Author:

{'name': 'Divjot Arora', 'email': 'divjot.arora@10gen.com', 'username': 'divjotarora'}

Message: GODRIVER-1615 Use custom deployment for change streams (#411)
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/ed2bb9904250129a51d8b98643ceabfc417983af

Comment by Divjot Arora (Inactive) [ 26/May/20 ]

https://github.com/mongodb/mongo-go-driver/pull/411

Generated at Thu Feb 08 08:36:46 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.