[GODRIVER-1806] DownloadStream.Skip() does not handle multiple chunks correctly Created: 03/Dec/20 Updated: 28/Oct/23 Resolved: 14/Jan/21 |
|
| Status: | Closed |
| Project: | Go Driver |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.4.5, 1.4.6 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Kevin Albertson | Assignee: | Kevin Albertson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
DownloadStream.Skip() does not seem to skip correctly when iterating over multiple chunks. The test cases here identify two cases: https://play.golang.org/p/z7RDRqU01ZA 1. Skipping less than chunk size if the buffer offset is 0 results in a no-op. |
| Comments |
| Comment by Githook User [ 01/Feb/21 ] |
|
Author: {'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}Message: |
| Comment by Githook User [ 14/Jan/21 ] |
|
Author: {'name': 'Kevin Albertson', 'email': 'kevin.albertson@mongodb.com', 'username': 'kevinAlbs'}Message: |
| Comment by Kevin Albertson [ 05/Jan/21 ] |
| Comment by Githook User [ 09/Dec/20 ] |
|
Author: {'name': 'ginuerzh', 'email': 'ginuerzh@users.noreply.github.com', 'username': 'ginuerzh'}Message: |
| Comment by Githook User [ 09/Dec/20 ] |
|
Author: {'name': 'ginuerzh', 'email': 'ginuerzh@users.noreply.github.com', 'username': 'ginuerzh'}Message: |
| Comment by Kevin Albertson [ 03/Dec/20 ] |
|
I believe https://github.com/mongodb/mongo-go-driver/pull/542 fixes case 1. I think we should merge it, fix the other case, and add tests. |