[GODRIVER-1953] Remove usages of "x/bsonx" BSON API from the "production" driver code Created: 08/Apr/21  Updated: 09/May/22  Resolved: 09/May/22

Status: Closed
Project: Go Driver
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Divjot Arora (Inactive) Assignee: Matt Dale
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to GODRIVER-2416 Completely remove "x/bsonx" package a... Closed
Epic Link: Typesafe BSON library

 Description   

The bsonx package contains Doc, Arr, Elem, and Val types that are largely unused. These were a POC of a typesafe BSON API and were used extensively in the 1.0 driver, but the usages were replaced by bsoncore when we refactored our operations layer in v1.1. We should remove these types as they are no longer useful for us and, as far as we're aware, are not used by internal/external consumers.

Updated reduced scope:

  • Remove all usages of "x/bsonx" API from the "production" driver code except where necessary to maintain backward compatibility with external usages of that package (e.g. in type switch statements).

The full scope is now captured in GODRIVER-2416.



 Comments   
Comment by Githook User [ 07/Apr/22 ]

Author:

{'name': 'Matt Dale', 'email': '9760375+matthewdale@users.noreply.github.com', 'username': 'matthewdale'}

Message: GODRIVER-1953 Remove bsonx from production code paths. (#893)

Co-authored-by: Luis Nieto <luis.nieto.pala@gmail.com>
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/5083299005f88684b5d7bb8f46280afec3df8bdc

Comment by Matt Dale [ 30/Mar/22 ]

luis.nieto.pala@gmail.com thank you for the helpful PR! I commented on your PR concerning updating your changes to be mergeable and complete:

I rebased these changes on the master branch and removed the remaining bsonx references from the "production" code paths in a new PR: #893. I believe you'll still get contributor credit when that PR is merged since one of the commits is yours. Please feel free to review or comment on the new PR. I'm closing this one in favor of the new one.

We will move forward with reviewing the new PR based on the one you opened. Thanks again!

Comment by Luis Nieto [ 22/Jun/21 ]

Hello!

I'm new to the mongodb go driver, and I'm interested in solving this issue. May I give it a try?

Thanks!

Generated at Thu Feb 08 08:37:30 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.