[GODRIVER-2059] Makefile can't find some commands Created: 23/Jun/21  Updated: 30/Mar/22

Status: Backlog
Project: Go Driver
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor - P4
Reporter: Luis Nieto Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Hi! I'm new to the mongdb go driver, and I would love to contribute. My question is: When I run make to run all the tests, it ouputs some errors at the end and then stops:

...

/bin/bash: golint: command not found
errcheck -exclude .errcheck-excludes ./bson/... ./mongo/... ./x/...
make: errcheck: No such file or directory
make: *** [errcheck] Error 1

 

I haven't modified a file yet, this is just the cloned repo. I have a mongod instance running in the default port (27017), and I ran go mod tidy. Is this normal? If not, could someone help me? Thank you very much for your time.



 Comments   
Comment by Matt Dale [ 07/Jul/21 ]

Hey luis.nieto.pala@gmail.com, thanks for reporting this issue! Looks like the make errcheck target (which is run as part of the default make targets) uses the errcheck linter, but doesn't check if it's available first.

A quick fix is to install errcheck by running

go get -u github.com/kisielk/errcheck

and ensure the installed binary is in your PATH by running errcheck.

The real solution is to update the Makefile to check if errcheck is available and install it if it's not. Unfortunately we won't be able to work on the real solution until after the MongoDB Server v5.0 release on July 13th.

Until then, please try to install errcheck manually and let me know if that resolves your issue. Thanks!

Generated at Thu Feb 08 08:37:44 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.