[GODRIVER-2107] Integration tests for observeSensitiveCommands Created: 26/Jul/21  Updated: 29/Sep/21  Resolved: 29/Sep/21

Status: Closed
Project: Go Driver
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Backlog - Core Eng Program Management Team Assignee: Benji Rewis (Inactive)
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Issue split
split from DRIVERS-1868 Integration tests for observeSensitiv... Closed
Upstream Changes Summary:

DRIVERS-1868:
Sync valid-pass tests for the unified test format to mongodb/specifications@6847048. Also note that some additional clarifications were added to the spec itself concerning implementation of observeSensitiveEvents (originally introduced in DRIVERS-1653); however, the behavior of the syntax has not been changed.

Documentation Changes: Not Needed

 Description   

Driver Changes: Sync valid-pass tests for the unified test format to mongodb/specifications@6847048. Also note that some additional clarifications were added to the spec itself concerning implementation of observeSensitiveEvents (originally introduced in DRIVERS-1653); however, the behavior of the syntax has not been changed.


Summary

DRIVERS-1653 introduced observeSensitiveCommands to the unified test runner (schema version 1.5); however, it did not include integration tests for the new syntax. The test cases pertaining to sensitive command redaction are not sufficient to verify that drivers have implemented the new syntax completely. This issue will add integration tests to do so.

Motivation

Who is the affected end user?

Drivers.

How does this affect the end user?

Does not affect the end user.

How likely is it that this problem or use case will occur?

It's quite possible that observeSensitiveCommands can be implemented incorrectly if drivers are only using the redaction tests in DRIVERS-1653 to verify their implementations.

If the problem does occur, what are the consequences and how severe are they?

The risk is an incorrect test runner implementation.

Is this issue urgent?

This should be done alongside DRIVERS-1653, but individual drivers can make that call.

Is this ticket required by a downstream team?

No.

Is this ticket only for tests?

Only tests.



 Comments   
Comment by Githook User [ 29/Sep/21 ]

Author:

{'name': 'Benjamin Rewis', 'email': '32186188+benjirewis@users.noreply.github.com', 'username': 'benjirewis'}

Message: GODRIVER-2107 Correctly ignore sensitive commands in unified test runner (#760)
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/665003d314600cc7a151dcb2e0437cf6895f7849

Comment by Benji Rewis (Inactive) [ 28/Sep/21 ]

There was a small bug in the Go driver unified test runner. Here's the test sync and bugfix: https://github.com/mongodb/mongo-go-driver/pull/760

Generated at Thu Feb 08 08:37:50 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.