[GODRIVER-2156] Enable all remaining golangci-lint linters and fix any identified issues Created: 15/Sep/21  Updated: 28/Oct/23  Resolved: 07/Nov/22

Status: Closed
Project: Go Driver
Component/s: None
Affects Version/s: None
Fix Version/s: 1.9.0

Type: Improvement Priority: Unknown
Reporter: Matt Dale Assignee: Matt Dale
Resolution: Fixed Votes: 0
Labels: size-medium
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Gantt Dependency
has to be done after GODRIVER-2603 Use errors API from Go 1.13 Closed
Related
related to GODRIVER-1066 linter issues Closed
related to GODRIVER-2642 Enable the exportloopref linter Closed
related to GODRIVER-2646 Enable the "errlint" golangci-lint li... Backlog
related to GODRIVER-1766 Clean up internal package Closed
related to GODRIVER-2952 Update context.Canceled equality comp... Closed
Epic Link: Improve Testing Suite
Quarter: FY23Q4

 Description   

Following up on PR #731, enable all commented-out default linters in .golangci.yml and fix any issues identified by running make lint.



 Comments   
Comment by Matt Dale [ 07/Nov/22 ]

Split the remaining "errlint" linter work to GODRIVER-2646. Closing this ticket.

Comment by Githook User [ 01/Dec/21 ]

Author:

{'name': 'Matt Dale', 'email': '9760375+matthewdale@users.noreply.github.com', 'username': 'matthewdale'}

Message: GODRIVER-2156 Enable misspell linter. (#822)
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/171c31ac7b77856cf5240b3c169735a46cae68b6

Comment by Githook User [ 30/Nov/21 ]

Author:

{'name': 'Matt Dale', 'email': '9760375+matthewdale@users.noreply.github.com', 'username': 'matthewdale'}

Message: GODRIVER-2156 Enable unparam linter. (#802)
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/2bc145d2249a484bfbf6f47bdc0da6095cce22ff

Comment by Githook User [ 30/Nov/21 ]

Author:

{'name': 'Matt Dale', 'email': '9760375+matthewdale@users.noreply.github.com', 'username': 'matthewdale'}

Message: GODRIVER-2156 Enable prealloc linter. (#799)
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/28b03a47d4117a108a609dfc518fb6e7e6012996

Comment by Githook User [ 18/Nov/21 ]

Author:

{'name': 'Matt Dale', 'email': '9760375+matthewdale@users.noreply.github.com', 'username': 'matthewdale'}

Message: GODRIVER-2156 Enable gosec linter. (#796)
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/7e62bcdd917aeb8c9d04630551eb819e9dce646a

Comment by Githook User [ 16/Nov/21 ]

Author:

{'name': 'Matt Dale', 'email': '9760375+matthewdale@users.noreply.github.com', 'username': 'matthewdale'}

Message: GODRIVER-2156 Enable makezero linter. (#801)
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/a21c36b9de4bfbe6d0237fb94949cf3307e89b7d

Comment by Githook User [ 16/Nov/21 ]

Author:

{'name': 'Matt Dale', 'email': '9760375+matthewdale@users.noreply.github.com', 'username': 'matthewdale'}

Message: GODRIVER-2156 Enable structcheck and varcheck linters. (#797)
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/5e714b30c7634689c7a42e36f06cdea51944d4da

Comment by Githook User [ 16/Nov/21 ]

Author:

{'name': 'Matt Dale', 'email': '9760375+matthewdale@users.noreply.github.com', 'username': 'matthewdale'}

Message: GODRIVER-2156 Enable nakedret linter. (#798)
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/c2cbeca604bcf052bcbccae4ce2def98a6722524

Comment by Githook User [ 16/Nov/21 ]

Author:

{'name': 'Matt Dale', 'email': '9760375+matthewdale@users.noreply.github.com', 'username': 'matthewdale'}

Message: GODRIVER-2156 Enable gosimple linter. (#795)
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/49fed909583ad57a75761d7fececc164d91c1b3c

Comment by Githook User [ 04/Nov/21 ]

Author:

{'name': 'Matt Dale', 'email': '9760375+matthewdale@users.noreply.github.com', 'username': 'matthewdale'}

Message: GODRIVER-2156 Enable unconvert linter. (#793)
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/223854caf2932b7d9aa42d3255eea2cb13acf8f3

Comment by Githook User [ 27/Oct/21 ]

Author:

{'name': 'Matt Dale', 'email': '9760375+matthewdale@users.noreply.github.com', 'username': 'matthewdale'}

Message: GODRIVER-2156 Enable unused linter. (#773)
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/432c3faaddd156011378b7d8fd46bcba9d1b8f58

Comment by Githook User [ 20/Oct/21 ]

Author:

{'name': 'Matt Dale', 'email': '9760375+matthewdale@users.noreply.github.com', 'username': 'matthewdale'}

Message: GODRIVER-2156 Enable deadcode linter. (#770)
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/ad46855e47e3374713339d0d56d651883add7b5f

Generated at Thu Feb 08 08:37:57 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.