[GODRIVER-2216] Change testKmsCtx expectedHost to be port-agnostic Created: 02/Nov/21  Updated: 28/Oct/23  Resolved: 02/Nov/21

Status: Closed
Project: Go Driver
Component/s: Testing
Affects Version/s: None
Fix Version/s: 1.7.4

Type: Task Priority: Major - P3
Reporter: Benji Rewis (Inactive) Assignee: Benji Rewis (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to GODRIVER-2217 Test with the latest libmongocrypt re... Backlog
Backwards Compatibility: Fully Compatible
Documentation Changes: Not Needed

 Description   

We recently changed the expectedHost in the testKmsCtx subtest of mongocrypt_test.go to include the default port 443 in the AWS KMS hostname.

For some reason, on Windows, the AWS KMS hostname does not include the port, so we should just check that the expected hostname (sans port) is included in the actual.



 Comments   
Comment by Githook User [ 02/Nov/21 ]

Author:

{'name': 'Benjamin Rewis', 'email': '32186188+benjirewis@users.noreply.github.com', 'username': 'benjirewis'}

Message: GODRIVER-2216 Change testKmsCtx expectedHost to be port-agnostic (#791)
Branch: release/1.7
https://github.com/mongodb/mongo-go-driver/commit/1715097b73d8eb4f3208c9b8589ee7e18e09de44

Comment by Githook User [ 02/Nov/21 ]

Author:

{'name': 'Benjamin Rewis', 'email': '32186188+benjirewis@users.noreply.github.com', 'username': 'benjirewis'}

Message: GODRIVER-2216 Change testKmsCtx expectedHost to be port-agnostic (#791)
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/51951abb2a964d207b87baf96e21659ce2d3d418

Comment by Benji Rewis (Inactive) [ 02/Nov/21 ]

https://github.com/mongodb/mongo-go-driver/pull/791

Generated at Thu Feb 08 08:38:05 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.