[GODRIVER-2531] is returning WaitQueueTimeoutError always correct when context is done? Created: 22/Aug/22 Updated: 28/Oct/23 Resolved: 08/Sep/22 |
|
| Status: | Closed |
| Project: | Go Driver |
| Component/s: | Error Handling |
| Affects Version/s: | 1.9.1 |
| Fix Version/s: | 1.11.0 |
| Type: | Improvement | Priority: | Unknown |
| Reporter: | Hyeonho Kim | Assignee: | Qingyang Hu |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
| Description |
|
when checkOut returns error, i wish there is a error message fit for context canceled. whether context is canceled or context deadline exceeded, `checkOut` fuction always returns `WaitQueueTimeoutError`. when deadline exceeded, returning `WaitQueueTimeoutError` is correct. but when context is canceled, returning a error message with waiting and canceled message makes more clear than timed out error message. |
| Comments |
| Comment by Githook User [ 07/Sep/22 ] |
|
Author: {'name': 'Hyeonho Kim', 'email': 'jwalag87@gmail.com', 'username': 'proost'}Message: |
| Comment by Hyeonho Kim [ 24/Aug/22 ] |
|
Version is v1.9.1 Okay. I send a PR within a few days. |
| Comment by Qingyang Hu [ 23/Aug/22 ] |
|
Hi jwalag87@gmail.com, a PR is always welcome. We can merge it into the codebase after review. BTW, can you please let us know the version of the driver and Golang you are using? Thank you! |
| Comment by Hyeonho Kim [ 23/Aug/22 ] |
|
if my proposal is reasonable, could i send a PR? or wait for terminating investigation? |