[GODRIVER-2607] Remove legacy shell from test scripts Created: 25/Oct/22  Updated: 22/Jan/24  Resolved: 20/Oct/23

Status: Closed
Project: Go Driver
Component/s: Evergreen Tools
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: PM Bot Assignee: Steve Silvester
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Issue split
split from DRIVERS-2328 Remove legacy shell from test scripts Implementing
Quarter: FY24Q1, FY24Q2
Upstream Changes Summary:

DRIVERS-2328:
The legacy shell will no longer be installed in the near future. Drivers are encouraged to remove all usages of the legacy shell in their drivers with this Go driver PR serving as inspiration.

All drivers that require the use of the legacy library are required to define the INSTALL_LEGACY_SHELL environment variable to a non-zero value when running MongoDB installation (either by running run-orchestration.sh or by manually invoking download_and_extract() from download-mongoldb.sh). This variable replaces the current SKIP_LEGACY_SHELL variable which will no longer be respected.

The upcoming changes can be tested by using the development branch for this change. In your evergreen functions, locate the git clone command that clones the drivers-evergreen-tools repository and replace it with this command:

git clone https://github.com/alcaeus/drivers-evergreen-tools.git --depth 1 --branch skip-legacy-shell-by-default $DRIVERS_TOOLS

This will show which of your build tasks still need the legacy shell, which can be installed using the INSTALL_LEGACY_SHELL environment variable in that specific task.

Documentation Changes Summary:

1. What would you like to communicate to the user about this feature?
2. Would you like the user to see examples of the syntax and/or executable code and its output?
3. Which versions of the driver/connector does this apply to?


 Description   

This ticket was split from DRIVERS-2328, please see that ticket for a detailed description.



 Comments   
Comment by Githook User [ 22/Jan/24 ]

Author:

{'name': 'Steven Silvester', 'email': 'steven.silvester@ieee.org', 'username': 'blink1073'}

Message: DRIVERS-2328 Add aws_setup convenience script (#365)

  • cleanup
  • fix handling of directory
  • get the right secrets
  • fix unbound var
  • clean up script
  • more cleanup
  • fix handling of file
  • activate venv
  • allow user to already exist
  • fix import
  • fixups
  • try again
  • ignore windows for now
  • debug
  • debug
  • move secrets handling out
  • fix typo
  • debug
  • use robust script dir
  • fix handling of token file
  • syntax
  • try adding os env
Comment by Githook User [ 08/Nov/23 ]

Author:

{'name': 'Steven Silvester', 'email': 'steven.silvester@ieee.org', 'username': 'blink1073'}

Message: GODRIVER-2607 [master] Remove legacy shell from test scripts (#1435)
Branch: release/1.12
https://github.com/mongodb/mongo-go-driver/commit/50cd97ddcb88d562be66258befb6a41e05f14f41

Comment by Githook User [ 08/Nov/23 ]

Author:

{'name': 'Steven Silvester', 'email': 'steven.silvester@ieee.org', 'username': 'blink1073'}

Message: GODRIVER-2607 [master] Remove legacy shell from test scripts (#1435)
Branch: release/1.12
https://github.com/mongodb/mongo-go-driver/commit/851b49ea9fbd7924a9ee272c6dbd22ab6619c119

Comment by Githook User [ 20/Oct/23 ]

Author:

{'name': 'Steven Silvester', 'email': 'steven.silvester@ieee.org', 'username': 'blink1073'}

Message: GODRIVER-2607 [master] Remove legacy shell from test scripts (#1435)
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/70b1fa64ef2999635ab843ae7d3a6b2dde07e118

Comment by Githook User [ 17/Oct/23 ]

Author:

{'name': 'Steven Silvester', 'email': 'steven.silvester@ieee.org', 'username': 'blink1073'}

Message: DRIVERS-2328 Add aws_setup convenience script (#365)

  • cleanup
  • fix handling of directory
  • get the right secrets
  • fix unbound var
  • clean up script
  • more cleanup
  • fix handling of file
  • activate venv
  • allow user to already exist
  • fix import
  • fixups
  • try again
  • ignore windows for now
  • debug
  • debug
  • move secrets handling out
  • fix typo
  • debug
  • use robust script dir
  • fix handling of token file
  • syntax
  • try adding os env
Comment by Steve Silvester [ 17/Oct/23 ]

https://github.com/mongodb/mongo-go-driver/pull/1429

Comment by Steve Silvester [ 12/Oct/23 ]

I believe this can be fixed using https://github.com/mongodb-labs/drivers-evergreen-tools/commit/52cf98c37afc5b29097265e5dbb70954d8c1469b, which should also address current failures on Windows.

https://spruce.mongodb.com/task/mongo_go_driver_aws_auth_test__version~4.4_os_aws_auth~windows_64_vsCurrent_latest_small_go_1_20_aws_auth_test_b4f5ef1e38c2ed396f403aee5ea39764286a5628_23_10_10_15_25_24/logs?execution=0

Generated at Thu Feb 08 08:39:00 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.