[GODRIVER-2649] Fix ReadConcern logic on RunCommand Created: 09/Nov/22  Updated: 06/Dec/23  Resolved: 06/Nov/23

Status: Closed
Project: Go Driver
Component/s: None
Affects Version/s: None
Fix Version/s: 2.0.0, 1.13.0, 1.13.1

Type: Task Priority: Major - P3
Reporter: Benji Rewis (Inactive) Assignee: Preston Vasquez
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Epic Link: Go Driver 2.0: Driver
Backwards Compatibility: Major Change
Documentation Changes: Not Needed
Documentation Changes Summary:

1. What would you like to communicate to the user about this feature?
2. Would you like the user to see examples of the syntax and/or executable code and its output?
3. Which versions of the driver/connector does this apply to?


 Description   

readConcern is not currently passed to the underlying operation in command.go. This means that ReadConcern is effectively a no-op, and when we try to pass the Database read concern, here, it is not actually inherited by the operation. We should pass readConcern to the underlying operation, but this would be backward-breaking, so we should wait until the next major release of the driver to fix this small bug.

Open questions:

  • Should we actually implement the readConcern logic or should we remove the ReadConcern option?


 Comments   
Comment by Githook User [ 03/Nov/23 ]

Author:

{'name': 'Steven Silvester', 'email': 'steven.silvester@ieee.org', 'username': 'blink1073'}

Message: GODRIVER-2649 [master] Remove RW Concern Logic from RunCommand (#1455)

Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/ec38db639fb6ee8addb22b1dd7be05c2ba9daa8b

Comment by Githook User [ 09/Nov/22 ]

Author:

{'name': 'Benjamin Rewis', 'email': '32186188+benjirewis@users.noreply.github.com', 'username': 'benjirewis'}

Message: GODRIVER-2649 Add TODOs for passing readConcern correctly for RunCommand. (#1126)

Co-authored-by: Matt Dale <9760375+matthewdale@users.noreply.github.com>
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/d3466eeae7a74c97bb6708e76779cf80a22cf805

Generated at Thu Feb 08 08:39:05 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.