[GODRIVER-2651] Operation returns nil error if original and retry have `NoWritesPerformed` label Created: 09/Nov/22 Updated: 28/Oct/23 Resolved: 08/Dec/22 |
|
| Status: | Closed |
| Project: | Go Driver |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.11.1 |
| Type: | Bug | Priority: | Unknown |
| Reporter: | Kevin Albertson | Assignee: | Preston Vasquez |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||
| Description |
|
Summary 1. If both the original and retry return errors with the NoWritesPerformed label, the operation returns nil. Here is a failing test reproducing the issue: https://github.com/kevinAlbs/mongo-go-driver/commit/ed23feeaaa69e7b7a47c2553c6a7866a595b57d9 2. The stored prevIndefiniteErr does not undergo further error processing. For example, the following is skipped when storing the prevIndefiniteErr:
That may result in incorrect Index if the prevIndefiniteErr is returned. |
| Comments |
| Comment by Githook User [ 08/Dec/22 ] |
|
Author: {'name': 'Preston Vasquez', 'email': '24281431+prestonvasquez@users.noreply.github.com', 'username': 'prestonvasquez'}Message: Co-authored-by: Qingyang Hu <103950869+qingyang-hu@users.noreply.github.com> |
| Comment by Githook User [ 08/Dec/22 ] |
|
Author: {'name': 'Preston Vasquez', 'email': '24281431+prestonvasquez@users.noreply.github.com', 'username': 'prestonvasquez'}Message: Release/1.11 (#1146)
Co-authored-by: Qingyang Hu <103950869+qingyang-hu@users.noreply.github.com>
Co-authored-by: Qingyang Hu <103950869+qingyang-hu@users.noreply.github.com> |
| Comment by Githook User [ 08/Dec/22 ] |
|
Author: {'name': 'Preston Vasquez', 'email': '24281431+prestonvasquez@users.noreply.github.com', 'username': 'prestonvasquez'}Message: Co-authored-by: Qingyang Hu <103950869+qingyang-hu@users.noreply.github.com> |