[GODRIVER-266] Properly implement maxAwaitTimeMS Created: 28/Feb/18 Updated: 28/Oct/23 Resolved: 21/Sep/18 |
|
| Status: | Closed |
| Project: | Go Driver |
| Component/s: | CRUD |
| Affects Version/s: | None |
| Fix Version/s: | 0.0.15 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Kristofer Brandow (Inactive) | Assignee: | Matthew Chiaravalloti |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | Stitch, beta, neweng, newgrad | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Epic Link: | Go FY2019Q3 Quick Wins | ||||||||||||||||
| Description |
|
The maxAwaitTimeMS option is broken for change streams and is not properly implemented for find options. It doesn't exist at all for aggregate options which needs to support maxAwaitTimeMS since $changeStream returns a tailableawait cursor. The current cursor implementation needs to be augmented with the ability to take a maxAwaitTime parameter, and that parameter needs to be sent on getMore requests when set. Additionally, the OptMaxAwaitTime option should implement the AggregateOptioner interface. Finally, when the Watch or a find or aggregate method receives an OptMaxAwaitTIme, it should not send it on the initial request and instead hold it and use that value when creating the cursor. |
| Comments |
| Comment by Githook User [ 21/Sep/18 ] |
|
Author: {'name': 'Matthew Chiaravalloti', 'email': 'matthew.chiaravalloti@mongodb.com', 'username': 'mattChiaravalloti'}Message: Fix maxAwaitTimeMS implementation Change-Id: Ie7f9ca4d0bf5f9fa75ca5332c48888157ef3f2de |