[GODRIVER-2675] Fix Evergreen License Linter Created: 07/Dec/22 Updated: 09/Jan/23 |
|
| Status: | Backlog |
| Project: | Go Driver |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor - P4 |
| Reporter: | Preston Vasquez | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
The license linter is not showing failures for files missing the Go Driver Apache 2.0 license header. |
| Comments |
| Comment by Benji Rewis (Inactive) [ 09/Jan/23 ] |
|
I looked into this briefly and believe the git diff --quiet in the add-license make target does not actually exit with error code 1 on the Ubuntu spawn host. The make target adds the licenses and generates a diff but does not error on Ubuntu (it does on my local Mac M2). The check-modules target relies on similar functionality and is probably similarly broken... Backlogging for now, as I have higher priority work. |