[GODRIVER-2781] Resolve linting failures resulting from "revive" bump Created: 21/Mar/23  Updated: 27/Mar/23  Resolved: 27/Mar/23

Status: Closed
Project: Go Driver
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Unknown
Reporter: Preston Vasquez Assignee: Unassigned
Resolution: Duplicate Votes: 0
Labels: greenerbuild
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
duplicates GODRIVER-2782 Fix "revive" v1.3.1 linter failures Closed
Documentation Changes Summary:

1. What would you like to communicate to the user about this feature?
2. Would you like the user to see examples of the syntax and/or executable code and its output?
3. Which versions of the driver/connector does this apply to?


 Description   

The sa-lint task in the static analysis build is currently failing. You can find an example of the failure here: https://evergreen.mongodb.com/task/mongo_go_driver_static_analysis_sa_lint_patch_48a21dbbcc3311297d503f0339f69704bdd07a2b_6418e02861837d0fb04aa8b8_23_03_20_22_37_43. The issue is related to the latest release of golangci-lint (version 1.52.0), which includes a revive bump that enforces the "recommended configuration". Unfortunately, this update has caused several linting failures in the Go Driver.

This fix will also require updating the evergreen config golangci-lint install command to use "latest" instead of "v1.51.2". PR #1211 was created to pin v1.51.2 to allow for green builds.


Generated at Thu Feb 08 08:39:21 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.