[GODRIVER-2824] Remove non-int64 Exported Connection IDs Created: 28/Apr/23  Updated: 23/Jan/24  Resolved: 07/Nov/23

Status: Closed
Project: Go Driver
Component/s: None
Affects Version/s: None
Fix Version/s: 2.0.0

Type: Task Priority: Unknown
Reporter: Preston Vasquez Assignee: Preston Vasquez
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on GODRIVER-2617 Remove or un-export all currently dep... Closed
Documented
Related
related to GODRIVER-2737 ConnectionId returned in heartbeats m... Closed
Epic Link: Go Driver 2.0: Driver
Backwards Compatibility: Major Change
Documentation Changes: Needed
Documentation Changes Summary:

1. What would you like to communicate to the user about this feature?
Any documentation reference to the following two fields:

CommandStartedEvent. ServerConnectionID64
CommandFinishedEvent. ServerConnectionID64

Should be replaced with

CommandStartedEvent. ServerConnectionID
CommandFinishedEvent. ServerConnectionID

Any reference to PoolEvent.ConnectionID as uint64 should be updated to reference as int64.

2. Would you like the user to see examples of the syntax and/or executable code and its output?

No that is not necessary, but any existing examples that illustrate the old logic must be updated.

3. Which versions of the driver/connector does this apply to?
v2


 Description   

GODRIVER-2737 changes the connection ID types on events to int64. To avoid breaking changes in the 1.x driver, we deprecate the old ServerConnectionID fields in favor of ServerConnectionID64. In the 2.0 version, these deprecated fields should be removed:

  • CommandStartedEvent.ServerConnectionID
  • CommandFinishedEvent.ServerConnectionID

In the case of PoolEvent.ConnectionID, the type needs to be updated to int64 to align with the specification here. This will also require updating the poolID pipeline from connection to operation, each member of the pipeline should be labeled with TODO(GODRIVER-2824).

Definition of done:

  • Change PoolEvent.ConnectionID to an int64.
  • Remove the deprecated ServerConnectionID fields from CommandStartedEvent and CommandFinishedEvent.
  • Update the internal representation of the connection pool's connection ID to int64 (from uint64).


 Comments   
Comment by Githook User [ 07/Nov/23 ]

Author:

{'name': 'Preston Vasquez', 'email': 'prestonvasquez@icloud.com', 'username': 'prestonvasquez'}

Message: GODRIVER-2824 Remove non-int64 Exported Connection IDs (#1459)
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/9fd042419788a742c93c466a9a52caa1b7e2750e

Comment by Kevin Albertson [ 01/May/23 ]

Consider renaming poolID to driverConnectionID and PoolID to DriverConnectionID to match the name in the Command Logging and Monitoring specification. poolID does not identify a pool, but rather a connection within a pool.

 

Update: the rename from poolID to driverConnectionID was applied in https://github.com/mongodb/mongo-go-driver/pull/1239

Generated at Thu Feb 08 08:39:27 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.