[GODRIVER-2846] Make expected TCP KeepAlive behavior explicit Created: 12/May/23 Updated: 08/Nov/23 Resolved: 01/Aug/23 |
|
| Status: | Closed |
| Project: | Go Driver |
| Component/s: | Networking |
| Affects Version/s: | None |
| Fix Version/s: | 1.12.2 |
| Type: | Improvement | Priority: | Unknown |
| Reporter: | Matt Dale | Assignee: | Qingyang Hu |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Documentation Changes: | Not Needed | ||||||||||||
| Documentation Changes Summary: | 1. What would you like to communicate to the user about this feature? |
||||||||||||
| Description |
|
The Go driver currently omits a KeepAlive configuration on the dialer used to dial new TCP connections, allowing the Go net package to use the default KeepAlive configuration (the default since Go 1.11 is KeepAlive enabled with an interval of 15s). Using the default was introduced with However, there are proposals to change the default KeepAlive behavior, either for all applications or in specific circumstances, like when the compile target is Android or iOS (see relevant issue). We should consider setting an explicit KeepAlive or continue using the default and document the rationale and desired behavior. Definition of done:
|
| Comments |
| Comment by Githook User [ 08/Nov/23 ] |
|
Author: {'name': 'Qingyang Hu', 'email': '103950869+qingyang-hu@users.noreply.github.com', 'username': 'qingyang-hu'}Message: |
| Comment by Githook User [ 01/Aug/23 ] |
|
Author: {'name': 'Qingyang Hu', 'email': '103950869+qingyang-hu@users.noreply.github.com', 'username': 'qingyang-hu'}Message: |