[GODRIVER-292] Use actual timeouts in tests for context.Context objects Created: 21/Mar/18 Updated: 24/Jul/20 Resolved: 24/Jul/20 |
|
| Status: | Closed |
| Project: | Go Driver |
| Component/s: | Testing |
| Affects Version/s: | 0.0.2 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Kristofer Brandow (Inactive) | Assignee: | Unassigned |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
Currently many tests use a context.Background() during their execution. This can cause problems if there is a bug in implementation because it can be difficult to find where a deadlock is occurring. We should ensure that all things that take a context.Context are given a context with a reasonable timeout. Seeing as the maximum time for running tests is 60 seconds in most cases, this timeout should be significantly less than that. |
| Comments |
| Comment by Sam Kleinman (Inactive) [ 18/May/18 ] |
|
can we also (as part of this or separately) remove the acceptance of nil contexts? |