[GODRIVER-2939] Clarify IsDuplicateKeyError()'s docs Created: 10/Aug/23 Updated: 28/Oct/23 Resolved: 18/Oct/23 |
|
| Status: | Closed |
| Project: | Go Driver |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 2.0.0 |
| Type: | Improvement | Priority: | Unknown |
| Reporter: | Felipe Gasper | Assignee: | Matt Dale |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Documentation Changes: | Not Needed |
| Documentation Changes Summary: | 1. What would you like to communicate to the user about this feature? |
| Description |
This doesn't answer the question of what happens in the case of "hybrid" WriteException errors (e.g., a dupe-key plus some other WriteError). It would be good for this function to clarify. (Based on the present implementation, as long as there is >=1 dupe-key error, the function returns true.) Aside: In driver v2 "HasDuplicateKeyEerror" might be a better name? |
| Comments |
| Comment by Githook User [ 18/Oct/23 ] |
|
Author: {'name': 'Ramit Mittal', 'email': 'commitemailoframit@protonmail.com', 'username': 'ramitmittal'}Message: Co-authored-by: Matt Dale <9760375+matthewdale@users.noreply.github.com> |
| Comment by Matt Dale [ 17/Oct/23 ] |
|
Community-contributed PR: https://github.com/mongodb/mongo-go-driver/pull/1418 |