[GODRIVER-2981] API comment doesn't work when job approver isn't PR author Created: 12/Sep/23  Updated: 25/Sep/23  Resolved: 25/Sep/23

Status: Closed
Project: Go Driver
Component/s: Build
Affects Version/s: None
Fix Version/s: None

Type: Build Failure Priority: Unknown
Reporter: Matt Dale Assignee: Steve Silvester
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Documentation Changes Summary:

1. What would you like to communicate to the user about this feature?
2. Would you like the user to see examples of the syntax and/or executable code and its output?
3. Which versions of the driver/connector does this apply to?


 Description   

E.g. build failure log for the comment action:

+ git clone https://github.com/mongodb/mongo-go-driver
Cloning into 'mongo-go-driver'...
+ cd mongo-go-driver
+ git remote add source https://github.com/qingyang-hu/mongo-go-driver
+ git fetch origin master
From https://github.com/mongodb/mongo-go-driver
 * branch              master     -> FETCH_HEAD
+ git fetch source cev/bson-allocs
fatal: couldn't find remote ref cev/bson-allocs
Error: Process completed with exit code 128.

See the full action here.

Seems to be caused by the $GITHUB_ACTOR not being equal to the PR author, so the remote doesn't have the expected branch. See here.



 Comments   
Comment by Githook User [ 19/Sep/23 ]

Author:

{'name': 'Steven Silvester', 'email': 'steven.silvester@ieee.org', 'username': 'blink1073'}

Message: GODRIVER-2981 [master] API comment doesn't work when job approver isn't PR author (#1394)
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/467dc08e69c8f73c3d0c411a864b01af836c8f1b

Comment by Steve Silvester [ 13/Sep/23 ]

https://github.com/mongodb/mongo-go-driver/pull/1383

Generated at Thu Feb 08 08:39:47 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.