[GODRIVER-3054] OP_QUERY isMaster used in load balancer mode Created: 21/Nov/23  Updated: 05/Dec/23  Resolved: 04/Dec/23

Status: Closed
Project: Go Driver
Component/s: None
Affects Version/s: 1.13.0
Fix Version/s: 2.0.0, 1.13.1

Type: Bug Priority: Major - P3
Reporter: Siyuan Zhou Assignee: Preston Vasquez
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by DRIVERS-2783 Test that LoadBalanced connection han... Backlog
Related
related to GODRIVER-2892 Remove all code that is only required... Closed
related to GODRIVER-2935 Use OP_QUERY in connection handshakes Closed
Documentation Changes: Not Needed
Documentation Changes Summary:

1. What would you like to communicate to the user about this feature?
2. Would you like the user to see examples of the syntax and/or executable code and its output?
3. Which versions of the driver/connector does this apply to?


 Description   

Context


We found in serverless tests that Go driver uses OP_QUERY with isMaster in load balancer mode. Howerver, the spec says OP_MSG must be used.

[2023/10/02 17:49:04.806] [ProxySession(60e60c6ccbd24f21a039c13a_,10673-drivers-testing-lb.2tzoa.mongodb-dev.net,3.236.71.14:54856).debug] [session_proxy.go:handleQueryMessage:498] got OP_QUERY isMaster
[2023/10/02 17:49:04.806] [ProxySession(60e60c6ccbd24f21a039c13a_,10673-drivers-testing-lb.2tzoa.mongodb-dev.net,3.236.71.14:54856).info] [session_proxy.go:handleClientMetadata:407] received client metadata from 3.236.71.14:54856:{"driver":{"name":"mongo-go-driver","version":"v1.13.0-prerelease"},"os":{"type":"linux","architecture":"amd64"},"platform":"go1.20.8"}

Definition of done

Hello commamnd with OP_MSG is used instead.

Pitfalls

What should the implementer watch out for? What are the risks?



 Comments   
Comment by Githook User [ 05/Dec/23 ]

Author:

{'name': 'Preston Vasquez', 'email': 'prestonvasquez@icloud.com', 'username': 'prestonvasquez'}

Message: GODRIVER-3054 Handshake connection should not use legacy for LB (#1482)
Branch: release/1.13
https://github.com/mongodb/mongo-go-driver/commit/09f6511ea732bd3e16319788e07475ce8fdd3682

Comment by Githook User [ 04/Dec/23 ]

Author:

{'name': 'Steven Silvester', 'email': 'steven.silvester@ieee.org', 'username': 'blink1073'}

Message: GODRIVER-3054 [master] Handshake connection should not use legacy for LB (#1487)

Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/ec2153b31e833a8ab8d207068da785a0e93396dd

Generated at Thu Feb 08 08:39:58 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.