[GODRIVER-341] Where should we retrieve a description.Server from during dispatching? Created: 04/Apr/18  Updated: 13/May/19  Resolved: 13/May/19

Status: Closed
Project: Go Driver
Component/s: Command & Dispatch
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Kristofer Brandow (Inactive) Assignee: Unassigned
Resolution: Done Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Epic Link: Core API

 Description   

During this code review comment, the question of where we should retrieve the server description from came up.

The question is: Should we store the required components of a description.Server on a connection and only use those required components in the commands or should we continue to use the description attached a topology.Server?



 Comments   
Comment by Kristofer Brandow (Inactive) [ 13/May/19 ]

In the new design we've moved description.Server to the driver.Connection type.

Comment by Jeffrey Yemin [ 04/Apr/18 ]

Most of what we care about once we have a connection is the wire version, and assuming that wire version doesn't change without restarting the server (which is currently true), it's safer to use the wire version off of an ismaster command run on the connection we're actually going to send the message on. Either we have the right wire version, or the connection is no good anymore because the server has been restarted.

Generated at Thu Feb 08 08:34:00 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.