[GODRIVER-369] Function mongo.newClient should not call topology.Connect Created: 19/Apr/18  Updated: 19/Apr/18  Resolved: 19/Apr/18

Status: Closed
Project: Go Driver
Component/s: CRUD
Affects Version/s: 0.0.3
Fix Version/s: 0.0.4

Type: Bug Priority: Major - P3
Reporter: Kristofer Brandow (Inactive) Assignee: Kristofer Brandow (Inactive)
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

The mongo.newClient function calls topo.Connect. This is the responsibility of the mongo.Client.Connect method and should not be done in the constructor. Remove the call to topo.Connect in the mongo.newClient function.



 Comments   
Comment by Githook User [ 19/Apr/18 ]

Author:

{'email': 'kris@mongodb.com', 'username': 'skriptble', 'name': 'Kris Brandow'}

Message: Fix tests to properly connect Client

GODRIVER-369

Change-Id: Ic4b01e85e5fc41669ea9675b7219122f13841429
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/41596f398056d7bb5da1f1bedefcc950c1036229

Comment by Githook User [ 19/Apr/18 ]

Author:

{'email': 'kris@mongodb.com', 'username': 'skriptble', 'name': 'Kris Brandow'}

Message: Fix mongo.newClient to not call topology.Connect

GODRIVER-369

Change-Id: I5af6ca7e779333c06bad5a4bbc205d16ec0675df
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/18007d8c158a15f29fa40028805948de3c1ce28d

Comment by Kristofer Brandow (Inactive) [ 19/Apr/18 ]

Code Review: https://review.gerrithub.io/c/408387/.

Generated at Thu Feb 08 08:34:04 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.