[GODRIVER-370] The ConnectTimeout ClientOption should be used when using the default Dialer Created: 19/Apr/18  Updated: 19/Apr/18  Resolved: 19/Apr/18

Status: Closed
Project: Go Driver
Component/s: Connections, CRUD, Networking
Affects Version/s: 0.0.3
Fix Version/s: 0.0.4

Type: Bug Priority: Major - P3
Reporter: Kristofer Brandow (Inactive) Assignee: Kristofer Brandow (Inactive)
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

The ConnectTimeout ClientOption should be used in the Connection package when dialing a connection with a default dialer. The ConnectTimeout method should be documented indicating that if the user uses a custom dialer that the ConnectTimeout will not be set for them and they will need to set it manually.



 Comments   
Comment by Githook User [ 19/Apr/18 ]

Author:

{'email': 'kris@mongodb.com', 'username': 'skriptble', 'name': 'Kris Brandow'}

Message: Make connection.New use the ConnectTimeout option

By default, when a user doesn't provide a custom Dialer, we should set
the Timeout property of the default net.Dialer.

GODRIVER-370

Change-Id: I4328425950700c8a6d3ed512b191ddea74a361e3
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/aafa7c051201aa5f8f1fbb66871e8a57c17100f7

Comment by Kristofer Brandow (Inactive) [ 19/Apr/18 ]

Code Review: https://review.gerrithub.io/c/408385/.

Generated at Thu Feb 08 08:34:04 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.