[GODRIVER-404] Spec tests should use the same format for bulk writes Created: 02/May/18 Updated: 03/Aug/20 Resolved: 03/Aug/20 |
|
| Status: | Closed |
| Project: | Go Driver |
| Component/s: | CRUD, Testing |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Rathi Gnanasekaran | Assignee: | Unassigned |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Description |
|
There are three changes, the first two are breaking. The two breaking changes are in three command-monitoring tests: "bulkWrite.yml", "unacknowledgedBulkWrite.yml" and "insertMany.yml": https://github.com/mongodb/specifications/commit/bebf9b688f64afdec46a860f102bad0841b04c02 The format of the "requests" array and "ordered" option changes from this:
To this:
This brings Command Monitoring tests in line with the Retryable Writes and forthcoming Transactions tests. The non-breaking change is in the Retryable Writes tests: https://github.com/mongodb/specifications/commit/c0ce96daac5661f2603bfa52c9b3f683c176a292 Before, the tests said in prose that all MongoClients should be created with retryWrites=true. Now, the tests include the following YAML:
The clientOptions are the same for all Retryable Writes tests. Interpreting this field now will prepare you for the Transactions tests, which make real use of the field. |
| Comments |
| Comment by Divjot Arora (Inactive) [ 03/Aug/20 ] |
|
The linked specifications commit changes the retryable writes and command monitoring spec tests. We are already fully synced for both of those. |