[GODRIVER-481] Remove bson/internal libraries Created: 01/Jul/18 Updated: 02/Jul/18 Resolved: 02/Jul/18 |
|
| Status: | Closed |
| Project: | Go Driver |
| Component/s: | BSON |
| Affects Version/s: | 0.0.8 |
| Fix Version/s: | 0.0.9 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Kristofer Brandow (Inactive) | Assignee: | Kristofer Brandow (Inactive) |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Description |
|
The BSON library currently uses two libraries that were added as internal packages instead of vendored. The jsonpretty package is not modified in a way that the extended JSON library requires. The jsonparser package is altered, but can be fixed by using a closure instead of changing the package's code. Remove these two libraries, update the required code, and add the upstream libraries to the vendor directory. |
| Comments |
| Comment by Githook User [ 02/Jul/18 ] |
|
Author: {'username': 'skriptble', 'name': 'Kris Brandow', 'email': 'kris@mongodb.com'}Message: Vendor and remove from internal JSON packages The jsonparser and jsonpretty packages were placed in bson/internal. Change-Id: I5594ab0e753b27a4a18d959ec047341d988d3876 |
| Comment by Kristofer Brandow (Inactive) [ 01/Jul/18 ] |
|
Code Review: https://review.gerrithub.io/c/mongodb/mongo-go-driver/+/417415. |