[GODRIVER-481] Remove bson/internal libraries Created: 01/Jul/18  Updated: 02/Jul/18  Resolved: 02/Jul/18

Status: Closed
Project: Go Driver
Component/s: BSON
Affects Version/s: 0.0.8
Fix Version/s: 0.0.9

Type: Improvement Priority: Major - P3
Reporter: Kristofer Brandow (Inactive) Assignee: Kristofer Brandow (Inactive)
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
causes GODRIVER-480 License violation of github.com/buger... Closed

 Description   

The BSON library currently uses two libraries that were added as internal packages instead of vendored. The jsonpretty package is not modified in a way that the extended JSON library requires. The jsonparser package is altered, but can be fixed by using a closure instead of changing the package's code. Remove these two libraries, update the required code, and add the upstream libraries to the vendor directory.



 Comments   
Comment by Githook User [ 02/Jul/18 ]

Author:

{'username': 'skriptble', 'name': 'Kris Brandow', 'email': 'kris@mongodb.com'}

Message: Vendor and remove from internal JSON packages

The jsonparser and jsonpretty packages were placed in bson/internal.
There were not changes necessary to jsonpretty and the only change to
jsonparser can be implemented in the bson package using a closure. This
commit moves the libraries to the vendor directory, uses the fully copy
of the library, and updates the necessary code.

GODRIVER-480
GODRIVER-481

Change-Id: I5594ab0e753b27a4a18d959ec047341d988d3876
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/dfce4ff9ddb1cfddb0d9e2c14fad3833f0847139

Comment by Kristofer Brandow (Inactive) [ 01/Jul/18 ]

Code Review: https://review.gerrithub.io/c/mongodb/mongo-go-driver/+/417415.

Generated at Thu Feb 08 08:34:18 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.