[GODRIVER-671] ValueDecoders and ValueEncoders should ensure that a value can be set or is valid first Created: 03/Dec/18 Updated: 27/Oct/23 Resolved: 28/Jul/20 |
|
| Status: | Closed |
| Project: | Go Driver |
| Component/s: | BSON |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Kristofer Brandow (Inactive) | Assignee: | Unassigned |
| Resolution: | Gone away | Votes: | 0 |
| Labels: | divjot-close, neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
ValueDecoder's and ValueEncoder's should check if a value is settable or valid, respectively first, before checking if checking if the next value from the ValueReader or ValueWriter is valid. Previously, this was checked first because there was a fast path for many Decoders and Encoders which no longer exists, so checking for a settable or valid value first makes sense and is consistent. |
| Comments |
| Comment by Divjot Arora (Inactive) [ 28/Jul/20 ] |
|
Our coders now check if values are settable. |