[GODRIVER-709] Topology.Connect ignores addServer errors Created: 15/Dec/18  Updated: 27/Oct/23  Resolved: 27/Aug/19

Status: Closed
Project: Go Driver
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor - P4
Reporter: Eric Daniels (Inactive) Assignee: Unassigned
Resolution: Gone away Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

See https://github.com/mongodb/mongo-go-driver/blob/master/x/mongo/driver/topology/topology.go#L131. The error is assigned by but is never checked and later squashed by Subscribe.



 Comments   
Comment by Divjot Arora (Inactive) [ 27/Aug/19 ]

Closing as this has been fixed in another ticket.

Comment by Eric Daniels (Inactive) [ 17/Dec/18 ]

No I did not. It just seems odd to ignore the error. Maybe a comment on the caller to say why it assigns the error but does nothing with would suffice? Maybe it shouldn't assign it at all.

Comment by Kristofer Brandow (Inactive) [ 17/Dec/18 ]

eric.daniels,

Did you discover a problem with this? Currently addServer doesn't return errors unless there is something wrong with the configuration.

--Kris

Generated at Thu Feb 08 08:34:47 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.