[GODRIVER-714] KeepAlive is not enabled by default Created: 17/Dec/18  Updated: 28/Oct/23  Resolved: 31/Jan/19

Status: Closed
Project: Go Driver
Component/s: Networking
Affects Version/s: None
Fix Version/s: 0.3.0

Type: Improvement Priority: Major - P3
Reporter: Jeffrey Yemin Assignee: Divjot Arora (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

When TCP KeepAlive configuration was removed in scope of GODRIVER-37 it was not enabled by default, as required by DRIVERS-383.   It should be.



 Comments   
Comment by Githook User [ 31/Jan/19 ]

Author:

{'name': 'Divjot Arora', 'email': 'divjot.arora@10gen.com', 'username': 'divjotarora'}

Message: Enable TCP Keepalive by default.

GODRIVER-714

Change-Id: I080f3bbab626161adbd51085ce56cfc3164e6355
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/06b083ef82d66f674aaab1d1ef7f16de8332fe44

Comment by Jeffrey Yemin [ 25/Jan/19 ]

They touch the same code, but is one really dependent on the other? If not, let's keep it separate, as there is other work that is higher priority.

Comment by Kristofer Brandow (Inactive) [ 25/Jan/19 ]

While we're doing this can we also do GODRIVER-147 since this will change the net.Dialer which is also where we would set DualStack to resolve that ticket.

Comment by Kristofer Brandow (Inactive) [ 17/Dec/18 ]

FYI: TCP keep alive will be enabled by default on connections starting in Go 1.12: https://github.com/golang/go/issues/23459.

Generated at Thu Feb 08 08:34:48 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.