[GODRIVER-726] Server.heartbeat uses no timeouts Created: 19/Dec/18  Updated: 28/Oct/23  Resolved: 07/Jan/19

Status: Closed
Project: Go Driver
Component/s: Networking, Server Discovery and Monitoring
Affects Version/s: None
Fix Version/s: 0.2.0

Type: Bug Priority: Major - P3
Reporter: Eric Daniels (Inactive) Assignee: Kristofer Brandow (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

The heartbeat method uses a context.Background() for two of its network operation which effectively lets a heartbeat wait forever. This can cause an issue for disconnecting clients that are waiting to send an empty struct on the done channel.



 Comments   
Comment by Githook User [ 07/Jan/19 ]

Author:

{'username': 'skriptble', 'email': 'kris@mongodb.com', 'name': 'Kris Brandow'}

Message: Use connectTimeoutMS for heartbeatTimeout

GODRIVER-726

Change-Id: I7041da51a9a056a149e1efc8a0baf8187e840d1a
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/813eb0499115372ebea02c822d9226a2c4a8ee3e

Comment by Kristofer Brandow (Inactive) [ 04/Jan/19 ]

Code Review: https://review.gerrithub.io/c/mongodb/mongo-go-driver/+/439157.

Comment by Jeffrey Yemin [ 26/Dec/18 ]

The relevant specification is here

Generated at Thu Feb 08 08:34:49 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.