[GODRIVER-727] Clean up mongo.newClient Created: 19/Dec/18  Updated: 28/Oct/23  Resolved: 19/Feb/19

Status: Closed
Project: Go Driver
Component/s: CRUD
Affects Version/s: None
Fix Version/s: 1.0.0-rc1

Type: Improvement Priority: Minor - P4
Reporter: Kristofer Brandow (Inactive) Assignee: Kristofer Brandow (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

The mongo.newClient function has been through many options design iterations and has some cruft left over from previous designs. Specifically, it handles overriding the ReadPreference and other types when they are nil, including reading them from the connection string. We should likely just be checking to see if they are nil and then adding the defaults, not read them from the connstring, which is handled by options.MergeClientOptions.



 Comments   
Comment by Githook User [ 19/Feb/19 ]

Author:

{'name': 'Kris Brandow', 'email': 'kris@mongodb.com', 'username': 'skriptble'}

Message: Update options and remove exposed x in mongo

GODRIVER-793
GODRIVER-747
GODRIVER-727

Change-Id: I5e057598d5e425f6b9837af2a1d08a122b7f00fc
Branch: master
https://github.com/mongodb/mongo-go-driver/commit/32946b1f8b9412a6a94e68ff789575327bb257cf

Comment by Kristofer Brandow (Inactive) [ 11/Feb/19 ]

Code Review: https://review.gerrithub.io/c/mongodb/mongo-go-driver/+/443815.

Generated at Thu Feb 08 08:34:49 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.