[GODRIVER-817] Fix killCursor helper in collection tests Created: 08/Feb/19 Updated: 28/Oct/23 Resolved: 13/Feb/19 |
|
| Status: | Closed |
| Project: | Go Driver |
| Component/s: | Testing |
| Affects Version/s: | None |
| Fix Version/s: | 1.0.0-rc1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Divjot Arora (Inactive) | Assignee: | Isabella Siu (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Description |
|
The killCursor helper in collection_internal_test.go calls driver.KillCursors, which performs server selection. Change the function to directly call the killCursors command to avoid selecting the wrong server.
EDIT: the test can't currently be moved to a lower level. Putting it in x/mongo/driver/topology prevents us from accessing the batch cursor's server field and putting it in x/monog/driver causes an import cycle with testutil. Current fix is to skip the test until this ticket is resolved. |
| Comments |
| Comment by Githook User [ 13/Feb/19 ] |
|
Author: {'name': 'Isabella Siu', 'email': 'isabella.siu@10gen.com', 'username': 'iwysiu'}Message: Change driver.KillCursors to not do server selection and fix tests. Co-authored-by: Divjot Arora <divjot.arora@10gen.com> Change-Id: I78b457f32df9ea53ec650e1de3fb6aa75fc78174 |