[GODRIVER-851] Remove host flag from integration tests Created: 26/Feb/19  Updated: 27/Oct/23  Resolved: 14/Apr/21

Status: Closed
Project: Go Driver
Component/s: Testing
Affects Version/s: 1.0.0-rc1
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Tim Fogarty Assignee: Unassigned
Resolution: Gone away Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

x/network/integration and x/mongo/driver/integration tests take in a -host flag which defaults to 127.0.0.1:27017. 

  1. This default means tests will fail if the cluster you're testing against doesn't have a member on localhost:27017
  2. It looks like this flag isn't being used

Removing this flag and setting the host from MONGODB_URI will give people more flexibility on how they run tests.



 Comments   
Comment by Kevin Albertson [ 14/Apr/21 ]

The -host flag no longer appears in integration tests. It was removed in x/mongo/driver/integration/main_test.go as of this commit: https://github.com/mongodb/mongo-go-driver/blob/8442d4a33f152efcc2edbdbe17b62f37edbeadc5/x/mongo/driver/integration/main_test.go

Comment by Jeffrey Yemin [ 14/Mar/19 ]

PR: https://review.gerrithub.io/c/mongodb/mongo-go-driver/+/446304

Generated at Thu Feb 08 08:35:06 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.