[GODRIVER-956] Legacy Find is not respecting limit Created: 11/Apr/19 Updated: 28/Oct/23 Resolved: 15/Apr/19 |
|
| Status: | Closed |
| Project: | Go Driver |
| Component/s: | CRUD |
| Affects Version/s: | 1.0.0 |
| Fix Version/s: | 1.0.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Jeremy Loy | Assignee: | Isabella Siu (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Wire Protocol 3.2 (Azure CosmosDB) |
||
| Issue Links: |
|
||||||||
| Description |
|
STR:
Create and execute a query that specifies limit. Observe that a multiple of batchSize documents are returned, not the value of limit. * if limit < batchSize, batchSize is returned * if limit >= batchSize, n * batchSize is returned Notes:
|
| Comments |
| Comment by Githook User [ 15/Apr/19 ] | |||||||
|
Author: {'name': 'iwysiu', 'username': 'iwysiu', 'email': 'isabella.siu@10gen.com'}Message: Change-Id: I28a7702b5f00f6de99cab45e9780c43574cc5b58 | |||||||
| Comment by Jeremy Loy [ 15/Apr/19 ] | |||||||
|
Awesome! Thank you for the quick fix Isabella | |||||||
| Comment by Githook User [ 15/Apr/19 ] | |||||||
|
Author: {'email': 'isabella.siu@10gen.com', 'name': 'iwysiu', 'username': 'iwysiu'}Message: Change-Id: I28a7702b5f00f6de99cab45e9780c43574cc5b58 | |||||||
| Comment by Jeremy Loy [ 12/Apr/19 ] | |||||||
|
@iwysiu and @Jeff.yemin I applied changest #4 locally for testing, and it does not work, however #3 does. The simple change was as follows:
The only change I made is moving the "return" statement outside of the err check. Simple mistake, but one that should be caught by tests/CI. I would make this change in Gerrit, but I cannot login, I keep getting an Internal Server Error. | |||||||
| Comment by Isabella Siu (Inactive) [ 11/Apr/19 ] | |||||||
|
code review url: https://review.gerrithub.io/c/mongodb/mongo-go-driver/+/450972 |