[JAVA-1254] Some helper methods wrapping commands do not call throwOnError on the result Created: 21/May/14 Updated: 01/Apr/16 Resolved: 26/Jun/14 |
|
| Status: | Closed |
| Project: | Java Driver |
| Component/s: | Command Operations |
| Affects Version/s: | 2.12.0 |
| Fix Version/s: | 2.12.3 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | John Morales | Assignee: | Ross Lawley |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
From what I gather, the general contract of the Collection and DB API methods is:
However from what I see there are several "helpers" that do not, making the pattern sort of inconsistent for users. The examples that I was able to find where throwOnError() is not called:
|
| Comments |
| Comment by Githook User [ 01/Aug/14 ] |
|
Author: {u'username': u'rozza', u'name': u'Ross Lawley', u'email': u'ross.lawley@gmail.com'}Message: Ensure helpers call throwOnError();
|
| Comment by Githook User [ 26/Jun/14 ] |
|
Author: {u'username': u'rozza', u'name': u'Ross Lawley', u'email': u'ross.lawley@gmail.com'}Message: Ensure helpers call throwOnError();
|
| Comment by Ross Lawley [ 25/Jun/14 ] |
|
https://github.com/mongodb/mongo-java-driver/pull/221 |