[JAVA-1416] Package level getCluster on DB is never used Created: 28/Aug/14  Updated: 30/Jan/15  Resolved: 24/Sep/14

Status: Closed
Project: Java Driver
Component/s: None
Affects Version/s: None
Fix Version/s: 3.0.0

Type: Improvement Priority: Major - P3
Reporter: Trisha Gee Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

I noticed that the package-visible getCluster method on DB is never called, and it's package level. Do we need this method? Can we deprecate/delete it?

Similarly the protected doGetCollection method - it either needs to be deprecated if not to be used any more, or tested to make sure it does what is expected (and isn't accidentally broken).



 Comments   
Comment by Githook User [ 30/Jan/15 ]

Author:

{u'username': u'jyemin', u'name': u'Jeff Yemin', u'email': u'jeff.yemin@10gen.com'}

Message: Removed unused non-public method in DB and unused private static field in DBCollection

JAVA-1416
Branch: master
https://github.com/mongodb/mongo-java-driver/commit/e08c7a16fcc6d8f001fafe8f26484e5f37a519a8

Comment by Githook User [ 24/Sep/14 ]

Author:

{u'username': u'jyemin', u'name': u'Jeff Yemin', u'email': u'jeff.yemin@10gen.com'}

Message: Removed unused non-public method in DB and unused private static field in DBCollection

JAVA-1416
Branch: 3.0.x
https://github.com/mongodb/mongo-java-driver/commit/e08c7a16fcc6d8f001fafe8f26484e5f37a519a8

Comment by Jeffrey Yemin [ 28/Aug/14 ]

DB.doGetCollection is protected abstract in 2.x (and implemented in DBApiLayer, which no longer exists). We did not deprecate it, but in 3.0 it is no longer abstract since DB is no longer abstract. Therefore it should stay and be tested.

Comment by Jeffrey Yemin [ 28/Aug/14 ]

DB.getCluster can be removed.

Generated at Thu Feb 08 08:54:35 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.