[JAVA-1694] Make Connection thread safe Created: 17/Mar/15  Updated: 03/Sep/15  Resolved: 23/Mar/15

Status: Closed
Project: Java Driver
Component/s: Async
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Ross Lawley Assignee: Unassigned
Resolution: Duplicate Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
duplicates JAVA-1674 Address race conditions in InternalSt... Closed

 Description   

In e5fd0e58 we simplified the InternalStreamConnection.

InternalStreamConnection had been observed in Jenkins as failing and produced some unexplained errors that suggested some logic / race condition in the code. See JAVA-1674 for examples.

Post 3.0 we should reinstate thread safe connections



 Comments   
Comment by Jeffrey Yemin [ 23/Mar/15 ]

Existing race conditions have been removed in scope of JAVA-1674

Comment by Githook User [ 18/Mar/15 ]

Author:

{u'username': u'rozza', u'name': u'Ross Lawley', u'email': u'ross.lawley@gmail.com'}

Message: Improved trace logging

Moved calling of the passed callback in openAsync to the end of the open callback

JAVA-1674 JAVA-1694
Branch: master
https://github.com/mongodb/mongo-java-driver/commit/d1019e4b910b8229b5c2c83934a91a4dbd9dcb2a

Comment by Githook User [ 18/Mar/15 ]

Author:

{u'username': u'rozza', u'name': u'Ross Lawley', u'email': u'ross.lawley@gmail.com'}

Message: Added try catch to streamFactory.create

JAVA-1674 JAVA-1694
Branch: master
https://github.com/mongodb/mongo-java-driver/commit/0b3ec2c4a41f19c6d5abb448b4f46c5835ac8a28

Comment by Githook User [ 18/Mar/15 ]

Author:

{u'username': u'rozza', u'name': u'Ross Lawley', u'email': u'ross.lawley@gmail.com'}

Message: InternalConnectionStream Logging improvements

Fixed open logging message order
Improved message when a read message is received and pending

JAVA-1674 JAVA-1694
Branch: master
https://github.com/mongodb/mongo-java-driver/commit/619379bfd6005a06b6d7ff66849900fb0cd2d5bf

Comment by Githook User [ 18/Mar/15 ]

Author:

{u'username': u'rozza', u'name': u'Ross Lawley', u'email': u'ross.lawley@gmail.com'}

Message: Added callbacks to assertions

So callbacks can use the assertion errors.

JAVA-1674 JAVA-1694
Branch: master
https://github.com/mongodb/mongo-java-driver/commit/b0b5280d8c3c64e8d38dbb86c69033437ec7c342

Comment by Githook User [ 18/Mar/15 ]

Author:

{u'username': u'rozza', u'name': u'Ross Lawley', u'email': u'ross.lawley@gmail.com'}

Message: Updated test timeouts for async operations

So that we capture the default MongoClientSettings timeout configurations.

JAVA-1674 JAVA-1694
Branch: master
https://github.com/mongodb/mongo-java-driver/commit/a636b416ebfbe6de2d867fc2b122aa7fdb689f03

Comment by Githook User [ 18/Mar/15 ]

Author:

{u'username': u'rozza', u'name': u'Ross Lawley', u'email': u'ross.lawley@gmail.com'}

Message: Improved connection logging

JAVA-1674 JAVA-1694
Branch: master
https://github.com/mongodb/mongo-java-driver/commit/71b130acf8409b1227b4d16be998bb09e399bcf9

Comment by Githook User [ 18/Mar/15 ]

Author:

{u'username': u'rozza', u'name': u'Ross Lawley', u'email': u'ross.lawley@gmail.com'}

Message: Reverted InternalStreamConnection

Made opened and isClosed atomic boolean
Updated opened before callback is called

JAVA-1674 JAVA-1694
Branch: master
https://github.com/mongodb/mongo-java-driver/commit/6601e07129825afdcd661fd552af7b0079e65bd7

Generated at Thu Feb 08 08:55:16 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.