[JAVA-2295] Buffer size used by GridFSBucket.downloadToAsyncOutputStream should be configurable Created: 02/Sep/16 Updated: 08/Jan/20 Resolved: 08/Jan/20 |
|
| Status: | Closed |
| Project: | Java Driver |
| Component/s: | GridFS |
| Affects Version/s: | 3.3.0 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Sean Fitts | Assignee: | Ross Lawley |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
The current implementation uses a 4MB buffer to perform the read. It would be nice if this were configurable via an option as is the case in the rest of the API (you can control chunk size, batch size, and read/write buffer sizes on other methods). |
| Comments |
| Comment by Githook User [ 08/Jan/20 ] |
|
Author: {'name': 'Ross Lawley', 'email': 'ross.lawley@gmail.com', 'username': 'rozza'}Message: Remove unused AsyncGridFS code
|
| Comment by Ross Lawley [ 07/Jan/20 ] |
|
I did find some code that can now be removed in 4.0: |
| Comment by Ross Lawley [ 07/Jan/20 ] |
|
This is no longer an issue as in 4.0 the driver has moved away from the hard to use AsyncInputStream & AsyncOutputStream implementations in favour of a ByteBuffer publisher API. With the new reactive streams API buffer size can be configured directly on the Publisher. |
| Comment by Sean Fitts [ 05/Sep/16 ] |
|
More a general observation that it should be configurable (pretty much everything else is) – though the 4MB size does raise concerns for high volume use. |
| Comment by Ross Lawley [ 05/Sep/16 ] |
|
Thanks for the ticket. The API follows the GridFS Specification and there is no set options for this scenario. Is the current default causing an issue or is it more of a general observation / desire that it should be configurable? Ross |