[JAVA-2734] Upgrade codenarc to version 1.1 Created: 15/Jan/18  Updated: 28/Oct/23  Resolved: 18/Jan/18

Status: Closed
Project: Java Driver
Component/s: Internal
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Minor - P4
Reporter: Farès Hassak Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: HTML File bson-reports.html    

 Description   

Hello,

I want to upgrade codeNarc to version 1.1 :

https://github.com/CodeNarc/CodeNarc/blob/master/CHANGELOG.md

I am particularly interested in bug fixes :

#279: TrailingWhitespace: Fix to also support Windows line endings.

Because I work on windows. And my PR failed on unix due to trailing whitespace.
See conversation :
https://github.com/mongodb/mongo-java-driver/pull/422
https://github.com/mongodb/mongo-java-driver/pull/434

But this release introduces new rules that make the build failed (see attachement).

We can exclude these new rules except these 2 rules :

BlockStartsWithBlankLine and BlockEndsWithBlankLine

which are easy to apply.

Or maybe we can excludes all new rules ?

What do you think ?

Farès



 Comments   
Comment by Githook User [ 18/Jan/18 ]

Author:

{'name': 'Farès Hassak', 'email': 'fares.hassak@gmail.com', 'username': 'fhassak'}

Message: JAVA-2734 : Upgrade codenarc to version 1.1
Branch: master
https://github.com/mongodb/mongo-java-driver/commit/08aeb385ab6ce01f28c7b26b8448f37d0d09b192

Comment by Farès Hassak [ 17/Jan/18 ]

https://github.com/mongodb/mongo-java-driver/pull/443

Comment by Farès Hassak [ 16/Jan/18 ]

yes, i will exclude all new rules except these 2 rules :

BlockStartsWithBlankLine and BlockEndsWithBlankLine

Comment by Jeffrey Yemin [ 16/Jan/18 ]

This sounds fine to me. Do you plan to submit a pull request?

Generated at Thu Feb 08 08:57:57 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.