[JAVA-2749] CheckStyle error: File does not end with a newline (Windows vs Unix) Created: 24/Jan/18 Updated: 28/Oct/23 Resolved: 25/Jan/18 |
|
| Status: | Closed |
| Project: | Java Driver |
| Component/s: | Build |
| Affects Version/s: | None |
| Fix Version/s: | 3.7.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Farès Hassak | Assignee: | Ross Lawley |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
| Description |
|
Hello, There is a checkStyle error when i build master branch on Windows : File does not end with a newline. By default, checkstyle use the system line separator. So, configure checkstyle to use "crlf" (Windows-style), "cr" (Mac-style), "lf" (Unix-style) http://checkstyle.sourceforge.net/config_misc.html#NewlineAtEndOfFile
Build is success on windows with this configuration Farès |
| Comments |
| Comment by Githook User [ 25/Jan/18 ] |
|
Author: {'name': 'Farès Hassak', 'email': 'fares.hassak@gmail.com', 'username': 'fhassak'}Message: |
| Comment by Farès Hassak [ 24/Jan/18 ] |
|
FYI, error is in class mongo-java-driver\driver-legacy\src\main\com\mongodb\Mongo.java This class already contains a new line at the end of the file (unix-style) and checkstyle, by default, use system line separator (windows-style for me)... |
| Comment by Farès Hassak [ 24/Jan/18 ] |